feat: add android announcement banner #7551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
1 flaky test on run #15406 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| swap flow logging > completes two swaps and verifies the TTS logging for the first, plus all intermediate steps along the way |
Screenshots
|
|
Review all test suite changes for PR #7551 ↗︎
JFrankfurt
reviewed
Nov 8, 2023
| @@ -1,105 +0,0 @@ | |||
| import { Trans } from '@lingui/macro' | |||
There was a problem hiding this comment.
nit: I think removal of the Base banner would ideally happen in a separate PR with its migration
JFrankfurt
reviewed
Nov 8, 2023
JFrankfurt
reviewed
Nov 8, 2023
JFrankfurt
reviewed
Nov 8, 2023
| } | ||
| ` | ||
| export const StyledQrCode = styled.img` | ||
| padding: 2px; |
There was a problem hiding this comment.
confirming 2px and not 4
There was a problem hiding this comment.
yes - qr code was too small so phil wanted to decrease padding
JFrankfurt
reviewed
Nov 8, 2023
| display: flex; | ||
| flex-direction: column; | ||
| align-items: flex-start; | ||
| gap: 2px; |
There was a problem hiding this comment.
confirming 2px here and not 4px
JFrankfurt
reviewed
Nov 8, 2023
JFrankfurt
approved these changes
Nov 8, 2023
natew
approved these changes
Nov 8, 2023
natew
approved these changes
Nov 8, 2023
natew
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new Android announcement banner. Approved by design 👍
Will delete hideBaseWalletBanner redux state var via migration in another PR
Description
Slack thread: https://uniswapteam.slack.com/archives/C060WANHWBB/p1699369785721189
Figma: https://www.figma.com/file/4DJrdsx1lPm5u409xyKDZj/%F0%9F%8D%84-%F0%9F%95%B8%EF%B8%8F-Spore---Web?type=design&node-id=14716-56627&mode=design&t=L0pXaQoI6uuAaq8N-0
Screen capture